You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
i can't see the reason for this change, which breaks all the drivers and muddies a perfectly clear naming convention.
i would like to:
change these names back. this is simple, but requires a simultaneous change to libavr32 and, alas, all the module repos (because there is no DAC driver, just pasted direct calls to SPI functions.) there might be other similar changes things so i'll come back to it at a later stage in aleph refactor, leaving this issue as a reminder (and in case someone wants to tell me why i shouldn't do this.)
and while i'm at it:
factor direct calls to DAC SPI out of module main code and into the lib, so changing details of board configuration doesn't impact modules in the future.
The text was updated successfully, but these errors were encountered:
encountered this discrepancy when refactoring aleph for building against libavr32
in aleph board conf header (https://github.com/tehn/aleph/blob/dev/avr32_lib/conf/aleph_board.h#L82)
we stick to the ASF conventions when defining the address of an SPI peripheral:
and defining a chip select index:
in skeleton/system/libavr32, there is only one
SPI
peripheral definition, andADC_SPI
etc are defined as the chip select numbers and not as peripheral addresses. like so:https://github.com/monome/libavr32/blob/master/conf/teletype/conf_board.h#L138
i can't see the reason for this change, which breaks all the drivers and muddies a perfectly clear naming convention.
i would like to:
libavr32
and, alas, all the module repos (because there is no DAC driver, just pasted direct calls to SPI functions.) there might be other similar changes things so i'll come back to it at a later stage in aleph refactor, leaving this issue as a reminder (and in case someone wants to tell me why i shouldn't do this.)and while i'm at it:
The text was updated successfully, but these errors were encountered: