SPI peripheral/CS naming issues #1
Closed
Labels
Comments
|
Both of these sound good to me. Add a |
|
we kind of stalled out on the aleph refactor (it's basically done on a branch, but hasn't been properly tested) but we did change the pin defines with PR #18 and related. i didn't bother refactoring TT code. closing this anyway since it's been over a year |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
encountered this discrepancy when refactoring aleph for building against libavr32
in aleph board conf header (https://github.com/tehn/aleph/blob/dev/avr32_lib/conf/aleph_board.h#L82)
we stick to the ASF conventions when defining the address of an SPI peripheral:
and defining a chip select index:
in skeleton/system/libavr32, there is only one
SPIperipheral definition, andADC_SPIetc are defined as the chip select numbers and not as peripheral addresses. like so:https://github.com/monome/libavr32/blob/master/conf/teletype/conf_board.h#L138
i can't see the reason for this change, which breaks all the drivers and muddies a perfectly clear naming convention.
i would like to:
libavr32and, alas, all the module repos (because there is no DAC driver, just pasted direct calls to SPI functions.) there might be other similar changes things so i'll come back to it at a later stage in aleph refactor, leaving this issue as a reminder (and in case someone wants to tell me why i shouldn't do this.)and while i'm at it:
The text was updated successfully, but these errors were encountered: