Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand MIDI-learn to all MIDI channels #853

Closed
okyeron opened this issue Jul 7, 2019 · 5 comments
Closed

Expand MIDI-learn to all MIDI channels #853

okyeron opened this issue Jul 7, 2019 · 5 comments

Comments

@okyeron
Copy link
Contributor

okyeron commented Jul 7, 2019

Looking at the menu.lua code for midi-learn it looks like it only works with CC messages on channel 1.

We could expand this to look at all the CC channels by

if data[1] > 176 and data[1] < 192 then -- all cc channels

but then we would need to store the channel number in m.params.map somewhere.

How best to do that?

@tehn
Copy link
Member

tehn commented Jul 8, 2019

midi learn overhaul is forthcoming in the new parameter system/menu/interface.

i'll be sure that channel is mappable.

@okyeron
Copy link
Contributor Author

okyeron commented Jul 8, 2019

Let me know if I can help :)

@okyeron
Copy link
Contributor Author

okyeron commented Jul 10, 2019

Additional feature request:

Make Levels controls mappable to midi CCs (system volume, input, mon, engine, tape, cut)

@rbxbx
Copy link

rbxbx commented Jul 10, 2019

as @okyeron suggests, I basically always want a (tactile) gain control for the norns. Relying on being attached to a mixer (that you have control over) is kind of a bummer, especially for lightweight sessions.

@tehn tehn added this to the 2.2.0 milestone Jul 11, 2019
@tehn tehn mentioned this issue Dec 2, 2019
20 tasks
@tehn tehn removed this from the 2.3.0 milestone Mar 5, 2020
@okyeron
Copy link
Contributor Author

okyeron commented Apr 20, 2020

Closing as this appears to be done with #960

@okyeron okyeron closed this as completed Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants