Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

average intervals for incoming midi clock events #1077

Merged
merged 2 commits into from Apr 10, 2020
Merged

average intervals for incoming midi clock events #1077

merged 2 commits into from Apr 10, 2020

Conversation

artfwo
Copy link
Member

@artfwo artfwo commented Apr 9, 2020

fixes #848

tehn
tehn approved these changes Apr 9, 2020
View reviewed changes
Copy link
Member

@tehn tehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good in code--- does it work well in testing? (can test in a couple hours)

@artfwo
Copy link
Member Author

artfwo commented Apr 9, 2020

the tempo looks much more stable with my midi clock source - op-1, but op-1 doesn't send out the "start" byte in a controlled way, so i can only sync actual melodies by ear :) must be good to merge after more testing with real world gear.

@tehn
Copy link
Member

tehn commented Apr 10, 2020

tested with arturia keystep = extremely improved.

@tehn tehn merged commit aa70084 into master Apr 10, 2020
@tehn tehn deleted the avg-clock-midi-events branch April 10, 2020 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tehn tehn tehn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

averaging intervals for midi clock source events
2 participants
@artfwo @tehn