Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update softcut to get phase inversion fix #1725

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Conversation

catfact
Copy link
Collaborator

@catfact catfact commented Oct 30, 2023

so it turns out, softcut has i think a pretty long standing bug where phase is inverted on recording! i don't think it was always there, but somewhere in messing around with fade curves a math error was introduced.

this pulls in actually a few changes from softcut main branch, but the only significant thing is the single change in FadeCurves.cpp.

apologies, i think people have pointed it out but we always thought it was some polarity issue elsewhere, i never thought to check the sign of the fade curve.

i almost wonder if we even should change the default behavior at this point.

@tehn
Copy link
Member

tehn commented Oct 31, 2023

good find, thank you. what would you prefer the default behavior to be? (i'm all for changing it if you prefer, since it seems best practice for scripts to explicitly set all params to desired values)

@tehn tehn merged commit d46c6c9 into main Nov 8, 2023
@tehn tehn deleted the softcut-phase-inversion-fix branch November 8, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants