metro syntax change #572
Merged
metro syntax change #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pq
approved these changes
Oct 2, 2018
lua/metro.lua
Outdated
| @@ -14,118 +14,123 @@ Metro.metros = {} | |||
| Metro.available = {} | |||
| Metro.assigned = {} | |||
|
|
|||
| --- assign | |||
|
|
|||
| --- init/assign | |||
| -- "allocate" a metro (assigns unused id) | |||
lua/metro.lua
Outdated
| local time = arg_time or 1 | ||
| local count = arg_count or -1 | ||
|
|
||
| print("what "..time) |
There was a problem hiding this comment.
remove (unless this is intended)?
| self.count = -1 | ||
| self.callback = nil | ||
| self.init_stage = 1 | ||
| local m = {} |
There was a problem hiding this comment.
while you're at it, consider a table constructor?
m.props = {
id = id,
time = 1,
count = -1,
...
}
lua/metro.lua
Outdated
| m.props.id = id | ||
| m.props.time = 1 | ||
| m.props.count = -1 | ||
| m.props.event = nil |
There was a problem hiding this comment.
isn't this nil already (or do we check for the key somewhere?)
| m.props.event = nil | ||
| m.props.init_stage = 1 | ||
| setmetatable(m, Metro) | ||
| return m | ||
| end | ||
|
|
||
| --- start a metro | ||
| -- @param time - (optional) time period between ticks (seconds.) by default, re-use the last period | ||
| -- @param count - (optional) number of ticks. infinite by default | ||
| -- @param stage - (optional) initial stage number (1-based.) 1 by default | ||
| function Metro:start(time, count, stage) |
There was a problem hiding this comment.
perhaps consider a similar table approach here? iow:
m:start{time = 0.1, count = 1, stage = 3}
|
@tehn do you still want to do this? |
|
holding off for the next breaking-change release, and need to do doc revisions which are not ready. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re: github.com//issues/570
this is a breaking change:
metro:init()removed as it was unused (simply resets metro to defaults)metro.allocis nowmetro.initcallbackrenamedeventinitie
and you can still
if you want.
much breakage in dust, however
metro.alloc->metro.initm.callback->m.eventcount is -1 by default, need not be specified
time is 1 by default, need not be specified
norns study must be updated (!)
this merge should coincide with dust fix and study fix