Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

map incoming osc to params #585

Merged
merged 1 commit into from Oct 7, 2018
Merged

map incoming osc to params #585

merged 1 commit into from Oct 7, 2018

Conversation

artfwo
Copy link
Member

@artfwo artfwo commented Oct 7, 2018

fixes #501

incoming numeric osc param values should be within the specific parameter range (i.e. -80, 20). file and option params require string argument value.

Copy link
Collaborator

@pq pq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

lua/paramset.lua Show resolved Hide resolved
lua/paramset.lua Show resolved Hide resolved
@tehn
Copy link
Member

tehn commented Oct 7, 2018

does the global params table (defined in startup.lua) need a name and id?

@artfwo
Copy link
Member Author

artfwo commented Oct 7, 2018

@tehn the current logic allows empty IDs - the script params can be addressed by /param/foo, mix params can be addressed by /params/mix/foo.

the "" id will be replaced by an empty paramset whenever a script is loaded, but additional sets can be created if we ever need to namespace parameters.

@artfwo artfwo merged commit ba6f9b7 into master Oct 7, 2018
@artfwo artfwo deleted the osc-param-mapping branch October 7, 2018 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

map incoming OSC to params
3 participants