Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup travis build. #28

Closed
2 tasks done
pq opened this issue Apr 6, 2016 · 10 comments
Closed
2 tasks done

Setup travis build. #28

pq opened this issue Apr 6, 2016 · 10 comments

Comments

@pq
Copy link
Contributor

pq commented Apr 6, 2016

A few bits:

  • setup .travis.ym; appropriately --- @samdoshi has proved this out (samdoshi@0a51dd8), so this shouldn't be too hard
  • add a build badge to the README
@pq
Copy link
Contributor Author

pq commented Apr 6, 2016

@tehn : looks like an admin needs to flip the bit on travis for teletype:

screen shot 2016-04-06 at 2 33 38 pm

https://travis-ci.org/profile/monome

Could you?

@tehn
Copy link
Member

tehn commented Apr 6, 2016

flipped

On Wed, Apr 6, 2016 at 5:35 PM, Phil Quitslund notifications@github.com
wrote:

@tehn https://github.com/tehn : looks like an admin needs to flip the
bit on travis for teletype:

[image: screen shot 2016-04-06 at 2 33 38 pm]
https://cloud.githubusercontent.com/assets/67586/14333624/9900ad62-fc04-11e5-8d42-d97511c47598.png

https://travis-ci.org/profile/monome

Could you?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#28 (comment)

@tehn
Copy link
Member

tehn commented Apr 6, 2016

i must say, i am completely baffled by the contents of .travis.yml

On Wed, Apr 6, 2016 at 5:35 PM, Phil Quitslund notifications@github.com
wrote:

@tehn https://github.com/tehn : looks like an admin needs to flip the
bit on travis for teletype:

[image: screen shot 2016-04-06 at 2 33 38 pm]
https://cloud.githubusercontent.com/assets/67586/14333624/9900ad62-fc04-11e5-8d42-d97511c47598.png

https://travis-ci.org/profile/monome

Could you?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#28 (comment)

@pq
Copy link
Contributor Author

pq commented Apr 6, 2016

Ha! I blame @samdoshi.

@tehn
Copy link
Member

tehn commented Apr 6, 2016

ah, it makes more sense now that i actually read about travis.

so right now we're just doing a compilation check, correct?

On Wed, Apr 6, 2016 at 6:23 PM, Phil Quitslund notifications@github.com
wrote:

Ha! I blame @samdoshi https://github.com/samdoshi.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#28 (comment)

@pq
Copy link
Contributor Author

pq commented Apr 6, 2016

so right now we're just doing a compilation check, correct?

Right. Once we have tests we should add them. Down the road we could add linting or some other kind of presubmit checks. Note that pull requests trigger a build which means you can see if a PR will break the build before accepting it.

For example:

screen shot 2016-04-06 at 4 02 27 pm

Which is pretty neat!

@pq
Copy link
Contributor Author

pq commented Apr 6, 2016

Added badge with cbb9fe8 which means this first bit is done.

@samdoshi or @tehn : feel free to re-open or create another issue if you want to see refinements to the travis build.

@pq pq closed this as completed Apr 6, 2016
@tehn
Copy link
Member

tehn commented Apr 6, 2016

looks good, thanks!

@samdoshi
Copy link
Collaborator

samdoshi commented Apr 7, 2016

i must say, i am completely baffled by the contents of .travis.yml

You and me both.

Should we get https://github.com/samdoshi/avr32-toolchain-linux moved over to the 'monome' org too?

@pq
Copy link
Contributor Author

pq commented Apr 7, 2016

Should we get https://github.com/samdoshi/avr32-toolchain-linux moved over to the 'monome' org too?

👍

Make sense to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants