Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ts.isDeclarationFile is not a function #135

Closed
rolandjitsu opened this issue Jun 12, 2017 · 8 comments
Closed

ts.isDeclarationFile is not a function #135

rolandjitsu opened this issue Jun 12, 2017 · 8 comments
Labels
Milestone

Comments

@rolandjitsu
Copy link

I think with the latest changes in TS v2.4, some of the APIs are gone, hence the error:

12 06 2017 22:51:36.120:ERROR [karma]: TypeError: ts.isDeclarationFile is not a function
    at /Users/rolandjitsu/Projects/potion-node/node_modules/karma-typescript/dist/compiler/compiler.js:71:39
    at Array.forEach (native)
    at Compiler.onProgramCompiled (/Users/rolandjitsu/Projects/potion-node/node_modules/karma-typescript/dist/compiler/compiler.js:64:24)
    at Compiler.compileProject (/Users/rolandjitsu/Projects/potion-node/node_modules/karma-typescript/dist/compiler/compiler.js:50:14)
    at Compiler.<anonymous> (/Users/rolandjitsu/Projects/potion-node/node_modules/karma-typescript/dist/compiler/compiler.js:26:23)
    at invokeFunc (/Users/rolandjitsu/Projects/potion-node/node_modules/lodash/lodash.js:10350:23)
    at trailingEdge (/Users/rolandjitsu/Projects/potion-node/node_modules/lodash/lodash.js:10397:18)
    at Timeout.timerExpired [as _onTimeout] (/Users/rolandjitsu/Projects/potion-node/node_modules/lodash/lodash.js:10385:18)
    at ontimeout (timers.js:365:14)
    at tryOnTimeout (timers.js:237:5)
    at Timer.listOnTimeout (timers.js:207:5)
@erikbarke erikbarke added the bug label Jun 13, 2017
@erikbarke erikbarke added this to the 3.0.4 milestone Jun 13, 2017
erikbarke added a commit that referenced this issue Jun 13, 2017
@erikbarke
Copy link
Collaborator

Hey @rolandjitsu, I've committed a fix for this now, does it work for you if you install from the development branch, npm i github:monounity/karma-typescript#next?

@rolandjitsu
Copy link
Author

@erikbarke I'll try it later and let you know if that works.

@rolandjitsu
Copy link
Author

It works. So I guess you can publish on NPM ...

@erikbarke
Copy link
Collaborator

Ok, closing 😃

@rolandjitsu
Copy link
Author

Do you think it'd be possible to publish a fix for this within the day? I cannot publish some of my packages due to failing tests 😆

@erikbarke
Copy link
Collaborator

The milestone 3.0.4 is 100% done now so I should be able to release today or tomorrow!

@erikbarke
Copy link
Collaborator

3.0.4 is on npm now!

@rolandjitsu
Copy link
Author

Just updated 🎉 , thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants