Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta 5 + latest Istanbul uses file path as directory for coverage output #359

Closed
erikbarke opened this issue Dec 4, 2019 · 5 comments
Closed
Labels
Milestone

Comments

@erikbarke
Copy link
Collaborator

From @dwightjack:

Hi, I tried v5.0.0-beta.0 but I encountered an unexpected behavior.

In my config, I've set up coverage reports for lconv as follows:

lcovonly: {
directory: 'coverage',
subdirectory: () => '',
filename: 'lcov.info',
},
In v4.x this was saving a coverage report to coverage/lcov.info which is one of the known paths scanned by CodeClimate.

After installing the beta version The file got saved to coverage/lcov.info/lcov.info.

Looks like istanbul is using the path generated by the configuration as a directory instead of a file path.

@erikbarke erikbarke added the bug label Dec 4, 2019
@erikbarke erikbarke added this to the 5.0.0 milestone Dec 4, 2019
@erikbarke
Copy link
Collaborator Author

@dwightjack, this seems to have been fixed in 5.0.0-beta.1, does it work as expected on your end?

@dwightjack
Copy link

@erikbarke I've tried to install the 5.0.0-beta.1 version but the problem seems to be still there. The project I'm woking on is public so I've set up a demo branch:

Project: https://github.com/dwightjack/yuzu

Steps to reproduce:

  1. Checkout branch feature/karma-ts-5
  2. yarn
  3. run CIRCLECI=true yarn test --browsers ChromeHeadlessCI
  4. generates a coverage/lcov.info/lcov.info file

Working setup:

  1. Checkout develop
    1.1 Remove node_modules, just in case.
  2. yarn
  3. run CIRCLECI=true yarn test --browsers ChromeHeadlessCI
  4. generates a coverage/lcov.info file

Let me know if you need any other info. Thanks!

@erikbarke
Copy link
Collaborator Author

@dwightjack, I was able to reproduce the issue now, thanks ☺️ 5.0.0-beta.3 is on npm now, does it work for you?

@dwightjack
Copy link

@erikbarke works great! Thank you! 🙇

@erikbarke
Copy link
Collaborator Author

5.0.0 on npm now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants