New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add possibility to apply comments for coverage settings in transforms #153
Conversation
see #152 |
This is a much better approach than the one I had in mind, it's simple yet effective 😃
So, in your case, the callback would be Also, for the sake of consistency in the Transforms API I think the If you don't want to wait for the ci servers to give you a slap on the wrist, just run the linter and the tests locally, the commands are in .travis.yml (*nix) and appveyor.yml (windows) in the root of the project. My apologies for creating a wall of text here, I'm posting from my phone so it's hard to use the code review tools... When this pr is done it's gonna be a really nice addition to the Transforms API 🎉 |
Are you still working on this PR? If not, I'll merge it as-is and make the suggested modifications myself, just let me know! |
Hey, I've modified the API, it looks like this now: karmaTypescriptConfig: {
bundlerOptions: {
transforms: [
function(context, callback) {
if(context.ts) {
context.ts.transpiled = "\n/* istanbul ignore next */\n" + context.ts.transpiled;
return callback(undefined, true, false);
}
return callback(undefined, false);
}
]
}
} The javascript code is in |
(y) nice! thanks mate! |
see #152