Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RequireJS lazy loading compatibility. #44

Merged
merged 1 commit into from
Dec 7, 2016
Merged

RequireJS lazy loading compatibility. #44

merged 1 commit into from
Dec 7, 2016

Conversation

to-kr
Copy link

@to-kr to-kr commented Dec 6, 2016

No description provided.

@erikbarke erikbarke merged commit 7c17d95 into monounity:master Dec 7, 2016
erikbarke added a commit that referenced this pull request Dec 7, 2016
@erikbarke
RequireJS lazy loading, #44:
6cfbccf 
* Checking if required is string
* Syntax fixes
@monounity
Copy link
Owner

Hey @to-kr, thanks! I had to fix some syntax issues and check typeof node.arguments[0].text === "string", otherwise it would break a lot of integration tests, it's in commit 6cfbccf above!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@to-kr @monounity @erikbarke @tokrsen