Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reports improvements: display total row and remove shipping column when the value is always 0 #17

Merged
merged 2 commits into from
Jun 22, 2023
Merged

Reports improvements: display total row and remove shipping column when the value is always 0 #17

merged 2 commits into from
Jun 22, 2023

Conversation

delyriand
Copy link
Member

Summary:

  • Remove the shipping amount column for report based on item values (like product, variant and option reports), because the amount is based on order
  • Display a total row after some reports

@maximehuran maximehuran merged commit 4a3591b into monsieurbiz:master Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximehuran maximehuran maximehuran approved these changes

Assignees
No one assigned
Labels
Status: needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@delyriand @maximehuran @madamebiz