Add Access-Control-Expose-Headers #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Access-Control-Expose-Headers While Access-Control-Allow-Headers lists the things (on a preflight request [ref](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Access-Control-Allow-Headers) ) which lists which HTTP headers will be available via Access-Control-Expose-Headers when making the actual request. But, this doesn't work if there's no Access-Control-Expose-Headers on the real requests, so some browsers will deny things as unsafe headers when they're outside of the list of hardcoded safe headers (https://developer.mozilla.org/en-US/docs/Glossary/Simple_response_header) (Cache-Control, Content-Language, Content-Type, Expires, Last-Modified, Pragma). I've also added Content-Range and Range to the headers, which are necessary for letting JS do much of anything useful with chunked requests.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Access-Control-Expose-Headers
While Access-Control-Allow-Headers lists the things (on a preflight request ref ) which lists which HTTP headers will be available via Access-Control-Expose-Headers when making the actual request. But, this doesn't work if there's no Access-Control-Expose-Headers on the real requests, so some browsers will deny things as unsafe headers when they're outside of the list of hardcoded safe headers (https://developer.mozilla.org/en-US/docs/Glossary/Simple_response_header) (Cache-Control, Content-Language, Content-Type, Expires, Last-Modified, Pragma).
I've also added Content-Range and Range to the headers, which are necessary for letting JS do much of anything useful with chunked requests.