Ignore property changes on non-configurables #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Safari, properties of hosted objects (particularly DOM elements) are not configurable so observing a property on a DOM element, even if to traverse to an observable object, would fail with an error. This change allows observers to proceed on the assumption that the non-configurable property will not be changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Safari, properties of hosted objects (particularly DOM elements) are
not configurable so observing a property on a DOM element, even if to
traverse to an observable object, would fail with an error. This change
allows observers to proceed on the assumption that the non-configurable
property will not be changed.
This change fixes kriskowal/tengwarjs#1