Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated usage of montage/core/bindings does not print out stack trace #1650

Open
cdebost opened this issue Dec 24, 2015 · 0 comments
Open

Comments

@cdebost
Copy link
Collaborator

cdebost commented Dec 24, 2015

May also apply to other deprecation warnings. The current behavior of the deprecation module is to never print out the stack trace, unless it is specifically asked by giving a truthy third parameter to deprecate's deprecationWarning(...). Also, it limits the stack trace to 2 if you simply give it true as the third parameter. 2 lines of stack trace is not useful, considering the first line will be the call to deprecationWarning() and the second will point out the file in which deprecationWarning() is called. E.g. 2 lines of stack trace on a "montage/core/bindings" warning would only point me to montage/core/bindings.js because that is where the deprecationWarning call is.

@hthetiot hthetiot added this to the v17.x milestone Apr 12, 2017
@hthetiot hthetiot self-assigned this Apr 12, 2017
@hthetiot hthetiot modified the milestones: v18.x, v17.0.x Apr 13, 2017
@hthetiot hthetiot modified the milestones: v17.0.x, v18.x Jun 17, 2017
@hthetiot hthetiot modified the milestones: v17.0.x Support, v17.1.x API Enhancements Sep 8, 2017
@hthetiot hthetiot modified the milestones: v17.1.x API Enhancements, v18.0.x new APIs/Features Oct 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants