Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could url resolve be speed up by building a cache? #65

Closed
marchant opened this issue Jan 26, 2012 · 4 comments
Closed

Could url resolve be speed up by building a cache? #65

marchant opened this issue Jan 26, 2012 · 4 comments
Assignees
Milestone

Comments

@marchant
Copy link
Member

in montage.js, exports.resolve = function (base, relative) {..}. It looks like the data set passed through may have multiple time the same value coming in and out, so if that's the case we could get some gains by building a cache and do a lookup first?

@ghost ghost assigned kriskowal Jan 26, 2012
@kriskowal
Copy link
Member

There’s a chance. I’ll look into it once bundling is done.

@kriskowal
Copy link
Member

Instrumenting resolve reveals that about 10% of all calls would be cache hits. The function gets called on the order of hundreds of times while loading.

@kriskowal
Copy link
Member

Sent to @marchant for verification.

@francoisfrisch
Copy link
Contributor

Verified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants