Massage the super method #1382
Open
Massage the super method #1382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes fail to fix MON-234 montagejsgh-1348, but in the process add comments, massage style, and fix theoretical internal consistency problems introduced by thrown exceptions and nested and repeated super calls, for which I have provided no evidence of their necessity.
| @@ -684,6 +764,9 @@ var getSuper = function(object, method) { | |||
| propertyName = propertyNames[i]; | |||
| property = Object.getOwnPropertyDescriptor(context, propertyName); | |||
| if ((func = property.value) != null) { | |||
| // TODO These deprecatedFunction checks should be | |||
| // unnecessary if the super methods are reentrant. | |||
| // - @kriskowal | |||
There was a problem hiding this comment.
Feedback about this would be good if anyone has prior knowledge of the motivations here.
There was a problem hiding this comment.
We are checking for the deprecatedFunction since the found func might be a method that is being used in "compatibility mode" i.e. a constructor method defined on the prototype.
|
Notes added to assist reviewers in distinguishing style noise from substantiative changes. |
|
Will need to take the time to review the addition of the contextStack |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes fail to fix MON-234 gh-1348, but in the process add
comments, massage style, and fix theoretical internal consistency
problems introduced by thrown exceptions and nested and repeated super
calls, for which I have provided no evidence of their necessity.