Add Succession, Transition & enable Component build-in / build-out CSS animation #1559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rayshan
force-pushed
the
feature-succession
branch
from
85452cb
to
2be778d
Compare
| CSSAnimationEndEventName: { | ||
| get: function () { | ||
| if (!this._CSSAnimationEndEventName) { | ||
| if (window.onanimationend === undefined && window.onwebkitanimationend !== undefined) { |
There was a problem hiding this comment.
not safe use void 0 or typeof
rayshan
force-pushed
the
feature-succession
branch
from
6ddd929
to
dc27182
Compare
rayshan
force-pushed
the
feature-succession
branch
from
dc27182
to
e78d902
Compare
|
@rayshan Where are we about this PR ? |
rayshan
changed the title
|
This is fully working and we're ready to use my fork with it for Contour (pending other Montage bugs being fixed). However it's not mergable due to missing tests. |
|
Ok thanks. what issues ? |
|
All known issues are fixed. We're using it now in Contour without any issues. The missing feature is animating an entire subtree of components upon removal, instead of animating just the topmost component. Also missing tests. |
- Ensure selection always has content - Use swap instead of clear / add to prevent setting selection multiple times
Within a mopped app the JSON content is already parsed and the property `text` is undefined.
rayshan
force-pushed
the
feature-succession
branch
from
3e4d9fa
to
3adfcff
Compare
|
@marchant debug steps for
Let me know if I can offer further assistance. |
hthetiot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Componentis enhanced to allow animation for both stand-alone components & components inside a placeholder likeSlotorSubstitution.Successionimplements astackto keep track of navigation. You canpush/pop/clearthe stack. You can also bind to thetop/previous/firstcomponents of the stack, e.g. to a Navigation Bar. The stack only tracks Components for now. Next step is to enable the use of aTransitionobject.See
succession.infofor usage. For live demo, serve/index.htmlthen selectSuccessionfrom drop-down.Video demo: https://www.youtube.com/watch?v=9F0SxMVXpgI
Usage & Design Docs: https://gist.github.com/rayshan/fd5ef874a3c648b81138
Known issues
When pushing onto then popping components off of the stack rapidly, sometimes components get stuck on the stack. It's likely the wayfixed_performDomContentChangesremoves children elements need improvement.Firefox isn't consistently hearing transition / animation end eventsfixedgetComputedStyleproperty inwillDrawbreaks build-in transition