Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blog post about changing a Set's definition of unique #72

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from

Conversation

Stuk
Copy link
Contributor

@Stuk Stuk commented Nov 27, 2013

No description provided.

@Stuk
Copy link
Contributor Author

Stuk commented Nov 27, 2013

Could you review, @kriskowal?

@kriskowal
Copy link
Member

At the moment, Set uses Object.equals, but this is probably a bug. It should use Object.is, which does referential identity, which is to say === except that Object.is(NaN, NaN) and Object.is(-0, -0). Object.equals does a fancier kind of equivalence, where object and array literals with equivalent values are equivalent, and where objects that implement an equals method on their prototype can define their own notion of equivalence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants