Allow Require.delegate to bypass loadScript #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tejaede
changed the title
|
Proposed as solution to montagejs/montage#2000 |
cdebost
approved these changes
Feb 11, 2019
|
@cdebost It's an interesting thought. Perhaps they are not mutually exclusive? The thing with |
|
@tejaede True. I'm fine with merging this PR if you think it's ready to go, looks pretty harmless. |
|
All good here! I'll merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide hook to allow developer to take over script loading. This allows the developer an entry point to do a variety of things without interfering with mr's caching/mapping/redirect, etc.
Possible use cases:
Application includes bundles that mr does not recognize. The developer can prevent an unnecessary HTTP request if a file is included in one of said bundles.
Application scripts are stored on the file system and the browser has access. The developer can retrieve the file directly from the system and prevent an unnecessary HTTP request