Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Normal Distribution #56

Merged
merged 6 commits into from Jan 22, 2020
Merged

Conversation

rvchess
Copy link
Contributor

@rvchess rvchess commented Jan 18, 2020

@coveralls
Copy link

coveralls commented Jan 18, 2020

Coverage Status

Coverage remained the same at 100.0% when pulling 5d15362 on rvchess:rubens_suite into 5391ebe on montanaflynn:master.

added my  functions into readme
@montanaflynn
Copy link
Owner

Thanks so much @rvchess! This looks like a wonderful addition to the library.

I have two small requests:

  1. Remove .idea directory.
  2. Use the convention of starting comments with the function name, from this link:

https://blog.golang.org/godoc-documenting-go-code

Notice this comment is a complete sentence that begins with the name of the element it describes. This important convention allows us to generate documentation in a variety of formats, from plain text to HTML to UNIX man pages, and makes it read better when tools truncate it for brevity, such as when they extract the first line or sentence.

So this:

// Probability density function.
func NormPdf(x float64, loc float64, scale float64) float64 {

Becomes:

// NormPdf is a probability density function.
func NormPdf(x float64, loc float64, scale float64) float64 {

Changed comments and removed .idea directory.
Copy link
Owner

@montanaflynn montanaflynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good besides the question of compatibility.

go.mod Outdated Show resolved Hide resolved
@montanaflynn
Copy link
Owner

@rvchess thanks so much for your contribution to stats! Everything looks good so I'm going to merge this PR 👍

@montanaflynn
Copy link
Owner

@rvchess I just noticed there is an empty file called go being added. Can you remove that?

Screen Shot 2020-01-22 at 12 40 41

@rvchess
Copy link
Contributor Author

rvchess commented Jan 22, 2020

It was fun! Unfortunately it seems that Go doesn't have any built in support for certain non elementary functions such as the hypergeometric, beta, etc. It also doesn't have much support for calculus operations which makes modeling other distributions pretty difficult. Enjoyed this one though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants