Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Themes are not working with Telescope v0.22.2 #8

Closed
cohnen opened this issue Aug 5, 2015 · 17 comments
Closed

Themes are not working with Telescope v0.22.2 #8

cohnen opened this issue Aug 5, 2015 · 17 comments

Comments

@cohnen
Copy link

cohnen commented Aug 5, 2015

There are a lot of UI issues once you update telescope to latest release. Is there something I can do to fix this? Do you plan to release an update soon?
Am I doing something wrong?

@montecruiseto
Copy link
Owner

I updated all the themes to v.0.22.2 this weekend, so should be good.
Don't forget to run meteor updatetoo.
If still bugs can you post them here? With screenshots please and in different issues if multiple. Thanks!

@cohnen
Copy link
Author

cohnen commented Aug 7, 2015

On your package dependencies still is mentioned 0.21.1
Here you can just check a live sample http://ixigo.meteor.com with Palomar theme. (Actually same issue is with other themes) I'm using there the last telescope and last theme version. It looks some CSS issue and also titles are coming empty.

By the way thanks a lot ;)

screen shot 2015-08-07 at 10 16 45 am

screen shot 2015-08-07 at 10 16 38 am

@montecruiseto
Copy link
Owner

ok I'll try to fix that this weekend

@cohnen
Copy link
Author

cohnen commented Aug 7, 2015

Sure! Thanks a lot.

Let me know if I you need more info from my side or some help on this.

Regards.

On Fri, Aug 7, 2015 at 3:32 PM, Samir notifications@github.com wrote:

ok I'll try to fix that this weekend


Reply to this email directly or view it on GitHub
#8 (comment)
.

Ernesto Cohnen de la Cámara
Mobile: +91 88 00 94 5550

@montecruiseto
Copy link
Owner

ok I updated all the dependencies and pushed to gh and atmosphere. Can you check if it fixed the problem?

@alexeski
Copy link

I am also trying to use the Palomar theme and can confirm that it's not working unfortunately. Here is how I tested: 1) downloaded the sample Telescope project, 2) updated it to latest version, 3) cleared sample posts, 4) changed to grid mode, configure embedly with right thumb size , 5) installed PAlomar theme, 6) try to post some youtube video --> At this point you can clearly see the theme is broken, the css/layout is all messed up.

I think the theme is really pretty and would love to use. Let me know if you need more info. Super thanks for your attention montecruiseto!

@cohnen
Copy link
Author

cohnen commented Aug 10, 2015

I can confirm it's still not working with last Telescope. It looks like
they have changed something on templating there.
Basic stuff like titles are not rendering.

I've reverted to telescope 0.21 and there everything works like a charm.

Thanks and Regards.

On Mon, Aug 10, 2015 at 10:43 AM, zebrie notifications@github.com wrote:

I am also trying to use the Palomar theme and can confirm that it's not
working unfortunately. Here is how I tested: 1) downloaded the sample
Telescope project, 2) updated it to latest version, 3) cleared sample
posts, 4) changed to grid mode, configure embedly with right thumb size ,
5) installed PAlomar theme, 6) try to post some youtube video --> At this
point you can clearly see the theme is broken, the css/layout is all messed
up.

I think the theme is really pretty and would love to use. Let me know if
you need more info. Super thanks for your attention montecruiseto!


Reply to this email directly or view it on GitHub
#8 (comment)
.

Ernesto Cohnen de la Cámara
Mobile: +91 88 00 94 5550

@alexeski
Copy link

I'll wait for a fixed version then. telescope .21 is not anymore possible for me due to customizations based on the new. Thanks for letting me know.

@DanielGillies
Copy link

I am on gemini and just tried starfire, both are having some issues as well. Just want you to know

@montecruiseto
Copy link
Owner

hey guys...just to let you know the ever so awesome @SachaG has done a PR for Palomar. I've not tested it, but went ahead and merged it anyways for you guys, and we will try to translate the changes to other themes. We also discussed the feasibility of more detailed migration guides for Telescope releases so that in the future it will be more easy to keep the themes updated and bug free. For the 0.21 and 0.22 releases, there were some changes which had not been described fully in the release notes and which required deep dives. Also, I simply didnt have that much time lately to really dig deep and stress-testing the theme updates. Any contributions are of course always welcome!

@cohnen
Copy link
Author

cohnen commented Aug 13, 2015

It works like a charm! For Palomar we can close this issue.

Thanks a lot to both of you! ;)

@alexeski
Copy link

super thanks to both of you, it's looking awesome now! Can't wait to see this PR coming :)

Some small issues:

  1. The Reply to post comment page is not rendered correctly. The workaround is to add a custom version of comment_reply.html template, replace class="posts posts-list" by class="posts posts-grid"

  2. Upvoting a comment will not change the icon. How could we fix that ?

  3. What is the right way to change the upvote icon to a heart?
    And 4) How can I have it become red when clicked?

I have 3 and 4 working fine on the original Telescope version adding the command Telescope.utils.icons.upvote = "heart"

Thanks a lot in advance!

@DanielGillies
Copy link

Okay excellent, I will maybe try to work on fixing one of the themes this weekend depending on how much time i have

@SachaG
Copy link
Contributor

SachaG commented Aug 14, 2015

@Zebrie if you want to override something that's already overridden in a theme, just define it in your own app's code and it'll be loaded after.

@DanielGillies cool! Don't hesitate to drop by the Slack channel if you have any questions, and to coordinate on what themes to work on :)

@montecruiseto
Copy link
Owner

I tested Laval and pushed an extra fix for the logo colour. This theme should now be completely ok.

@SachaG I tried to run Palomar but I get this error:
screen shot 2015-08-16 at 14 32 55

@SachaG
Copy link
Contributor

SachaG commented Aug 16, 2015

@montecruiseto hmm, does this happen with a fresh Telescope install?

@montecruiseto
Copy link
Owner

Hey guys. Unfortunately I'm discontinuing support on Scopemount but the themes will remain accessible as inspirational showcases for your own designs: http://scopemount.startrack.io/
You are of course free to borrow from them however you see fit, or to keep one or more themes alive through a fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants