Fixed storybook empty issue when building with yarn & iOS #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Generated yarn.lock * Upgraded @storybook/react-native & @storybook/addon-knobs to 3.3.3
|
Hi @patw0929, thanks for your PR. I will check it after New Year's holidays. Happy New Year ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made the pull request because when I try to run storybook in my environment (iOS Simulator & installed with
yarn), it failed.I got this error after installed with
yarnand ranyarn storybook:And got this when ran
react-native run-ios:This pull request do the following things:
Ref: react-native-xcode error after upgrading to 0.46 facebook/react-native#14935
Please review it and thank you for this awesome component! 👍