Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TravisCI #28

Closed
ziflex opened this issue Sep 27, 2018 · 10 comments
Closed

Fix TravisCI #28

ziflex opened this issue Sep 27, 2018 · 10 comments
Labels
good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed

Comments

@ziflex
Copy link
Member

ziflex commented Sep 27, 2018

The problem is that I cannot install ANTLR4 properly in order to generate parser.

@ziflex ziflex added help wanted Extra attention is needed good first issue Good for newcomers labels Sep 27, 2018
@yiss
Copy link

yiss commented Oct 3, 2018

@ziflex is it only a problem with TravisCi ? have you tried CircleCi ?

@ziflex
Copy link
Member Author

ziflex commented Oct 3, 2018

@yiss yep. I haven't tried it.
If it works on CircleCi - I'm fine to use it :)

u5surf added a commit to u5surf/ferret that referenced this issue Oct 4, 2018
u5surf added a commit to u5surf/ferret that referenced this issue Oct 4, 2018
u5surf added a commit to u5surf/ferret that referenced this issue Oct 4, 2018
u5surf added a commit to u5surf/ferret that referenced this issue Oct 4, 2018
@krishnakarthik9
Copy link
Contributor

@ziflex, @yiss submitted a PR #35

u5surf added a commit to u5surf/ferret that referenced this issue Oct 4, 2018
ziflex added a commit that referenced this issue Oct 4, 2018
fix travis-ci(#28): use shell script instead of aliases
@ziflex
Copy link
Member Author

ziflex commented Oct 4, 2018

@krishnakarthik1309 hey, thanks for your help.
It works now, but it seems that Antlr4 does not generate anything. It just renders list of commands. Probably arguments are not being passed.

@krishnakarthik9
Copy link
Contributor

krishnakarthik9 commented Oct 4, 2018

screenshot from 2018-10-04 21-28-54
@ziflex As you can see even when I run the antlr4 command from terminal in directory $GOPATH/src/github.com/MontFerret/ferret/pkg/parser it is just giving list of commands. So the problem is not with golang code. Most likely something with antlr4(I am not sure). Try to run this in your system and if it is working then tell me which version of antlr4 you are using.

@ziflex
Copy link
Member Author

ziflex commented Oct 4, 2018

It works fine on macOS. Otherwise I wouldn't be able to generate the parser :)
screenshot 2018-10-04 12 04 22

Try via either make generate or go generate ./pkg/...

@krishnakarthik9
Copy link
Contributor

Can you show the output of cd pkg/parser and then run antlr4 -Xexact-output-dir -o fql -package fql -visitor -Dlanguage=Go antlr/FqlLexer.g4 antlr/FqlParser.g4

@krishnakarthik9
Copy link
Contributor

Sry no need understood the problem.. will try to fix it.

@krishnakarthik9
Copy link
Contributor

This PR #37 will fix it by sending arguments to antlr4. You can view current travis-build output here

ziflex added a commit that referenced this issue Oct 4, 2018
fix travis build: send arguments to antlr4 #28
@ziflex
Copy link
Member Author

ziflex commented Oct 4, 2018

@krishnakarthik1309 thank you for your help, finally we can close the issue.

@ziflex ziflex closed this as completed Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants