Added YouTube video ID to talks and embedded videos for past talks #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should I presume from the above coverage decrease alert that that PR will not be accepted on those grounds? |
|
Yep. I can do the review in parallel, but coverage requirement has to be met. |
|
No problem. I'll add some coverage tonight. |
sophiedeziel
requested changes
Feb 22, 2018
| @@ -9,6 +9,11 @@ | |||
|
|
|||
| <h4><%= render_markdown_as_html "#{talk.title.titleize}, by #{talk.member.name}" %></h4> | |||
|
|
|||
| <% if talk.event&.starts_at&.past? && talk.youtube_id.present? %> | |||
| <iframe src="https://www.youtube.com/embed/<%= talk.youtube_id %>?rel=0&autoplay=0" frameborder="0" allowfullscreen width="640" height="360"></iframe> | |||
There was a problem hiding this comment.
This pull-request is pretty simple and very good. The only suggestion I would make is create a helper for the youtube tag
sophiedeziel
approved these changes
Mar 6, 2018
|
I'm merging, even with my suggestion. I understand that you might not have the time to make that change and this is adding a lot of value to the project as is. Thank you for opening that pull-request! |
shalstein
pushed a commit
to shalstein/Montreal.rb
that referenced
this pull request
Jun 24, 2018
shalstein
pushed a commit
to shalstein/Montreal.rb
that referenced
this pull request
Jun 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pull request introduces embedded YouTube videos for past talks as proposed in #277.
This feature does the following:
youtube_idstring column to the Talk modelyoutube_idfield to the talk dashboard<iframe>video if the talk is both in the past and has a non-nilyoutube_id