Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP] Generate "traits.py" via PHP frontend #7

Closed
sk33z3r opened this issue Mar 15, 2022 · 9 comments
Closed

[PHP] Generate "traits.py" via PHP frontend #7

sk33z3r opened this issue Mar 15, 2022 · 9 comments
Assignees
Labels
enhancement New feature or request

Comments

@sk33z3r
Copy link
Collaborator

sk33z3r commented Mar 15, 2022

It would be nice to have a web form where users could enter information in a more streamlined way, then output json for use in python.

@sk33z3r sk33z3r self-assigned this Mar 15, 2022
@sk33z3r sk33z3r added the enhancement New feature or request label Mar 15, 2022
@sk33z3r
Copy link
Collaborator Author

sk33z3r commented Mar 16, 2022

We should make this a localized UI, that is never hosted anywhere. This is only to give the user a nice entry form to make their traits and generate the proper environment files we need to run the generators.

The other reason we do it locally is so that we can take in the private keys and save them to the .env without allowing that key to get passed online anywhere.

This should curb a LOT of confusion in the setup, but is going to require some logic to put together.

@sk33z3r
Copy link
Collaborator Author

sk33z3r commented Mar 21, 2022

@Montspy Do you think this is too much? I'm not sure if we should put the minting stuff in here or not. Just an initial thought, open to ideas.

https://github.com/sk33z3r/LooPyGen/blob/dev/json-traits/traits.example.json

@Montspy
Copy link
Owner

Montspy commented Mar 21, 2022

Since the goal is to remove the need for the user to even think about .env, we should add the following to some json configuration file:
Account ID, NFT type, Fee token ID
We could split generation and minting config files into 2:
traits.json and mint.json to avoid confusing users that on-board and just want to generate for now.

@sk33z3r
Copy link
Collaborator Author

sk33z3r commented Mar 21, 2022

That makes sense. I suppose we have the user create and place traits.json into each of their collection folders, then mint.json can stay in the top level since it is universal.

I think we should continue to make the PK the sole item in .env just so it's isolated, and no one accidentally shares it with mint.json config. Perhaps the API key should remain in .env as well, no one really has a need to share either of those two items.

On the front end, I will still ask for all the info and separate out for them.

@Montspy
Copy link
Owner

Montspy commented Mar 21, 2022

For the API key, I created issue Montspy/LooPyMinty#16
We could get it from Loopring's API https://docs.loopring.io/en/dex_apis/getApiKey.html

@sk33z3r
Copy link
Collaborator Author

sk33z3r commented Mar 21, 2022

Oh, I like that. Less the user has to copy into files from the export, as well.

@sk33z3r
Copy link
Collaborator Author

sk33z3r commented Apr 2, 2022

PR #34 opened

@sk33z3r
Copy link
Collaborator Author

sk33z3r commented Apr 2, 2022

@Montspy Here is the output JSON that the generator will need to pull in for traits and setting up a collection

https://github.com/sk33z3r/LooPyGen/blob/dev/json-traits/traits.example.json

@sk33z3r sk33z3r changed the title Generate "traits.py" via PHP frontend [PHP] Generate "traits.py" via PHP frontend Apr 4, 2022
@sk33z3r
Copy link
Collaborator Author

sk33z3r commented Apr 5, 2022

Feature is implemented as of #34

@sk33z3r sk33z3r closed this as completed Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants