Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP UI for JSON Traits #34

Merged
merged 47 commits into from
Apr 5, 2022
Merged

PHP UI for JSON Traits #34

merged 47 commits into from
Apr 5, 2022

Conversation

sk33z3r
Copy link
Collaborator

@sk33z3r sk33z3r commented Apr 2, 2022

Initial UI in place where users can manually add in the trait information into a web form, instead of editing JSON directly.

Features to be implemented before merge:

  • Clean up aesthetics
  • Update README
  • Simple instructions in the UI
  • Generate config.json
  • Convert RGB inputs to a color picker
  • Convert filename fields to file browsers

We'll create other pull requests for future features here, like running the whole process from the UI.

@sk33z3r sk33z3r added the enhancement New feature or request label Apr 2, 2022
@sk33z3r sk33z3r requested a review from Montspy April 2, 2022 07:27
@sk33z3r sk33z3r self-assigned this Apr 2, 2022
@sk33z3r
Copy link
Collaborator Author

sk33z3r commented Apr 2, 2022

@Montspy

Note about directories:

I got rid of the example collection_name folder since the UI will handle this, and moved images to collections. I think it is more fitting to how things are structured now.
I didn't actually make this change, I thought I did.

Notes about the JSON traits output:

  • The artist_address is optional. If the user doesn't input it, then I don't add it.
  • background_color is a bit misleading. It's a flipped boolean, so 0 actually means YES in this case. Basically the front end is telling the backend "If the user wants a background color, start at layer00. If not, start at layer01."
  • traits and variations are purely for my front-end and may not serve any purpose in python.
  • I run the rarity in a simple way:
Rarity Value
Legendary 1
Rare 2
Uncommon 3
Common 4

I think this will work properly, but perhaps we need to adjust those values.

@sk33z3r
Copy link
Collaborator Author

sk33z3r commented Apr 2, 2022

Couple other notes:

  • I put the minter_address in the collection traits.json instead of a main config.json, because I think there will be cases where the minter/artist does not match up. It would likely be on a per collection basis, so it made sense add this in here.
  • artist_name and artist_address are intended to be added to metadata files as their own fields.

@sk33z3r
Copy link
Collaborator Author

sk33z3r commented Apr 4, 2022

@Montspy finally remembered to put collection_lower in the json...

@sk33z3r
Copy link
Collaborator Author

sk33z3r commented Apr 4, 2022

@Montspy this PR is ready when you have your side sorted and confirm there are no more changes needed in PHP. I opened other tickets since I think it is in a good enough place for testers.

Before we attempt to merge, should we review and merge in #30 first?

@Montspy
Copy link
Owner

Montspy commented Apr 4, 2022

@sk33z3r I think we should merge this before #30 simply because we've both tested this branch more than #30.
In terms of merge conflicts, I don't see a big difference in the merge order between this branch and #30.

I released a new version of LooPyMinty for this branch, make sure to update your submodules!
This new release adds:

  • resolve ENS, account IDs and ETH addresses for minter and royalty_address
  • loads the current traits.json and config.json

@sk33z3r sk33z3r marked this pull request as ready for review April 5, 2022 01:48
@sk33z3r sk33z3r merged commit dce9ed5 into main Apr 5, 2022
@sk33z3r sk33z3r deleted the dev/json-traits branch April 5, 2022 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants