Sourcery refactored master branch #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Comment on lines
-177
to
+181
| warnings.warn(("The %s method is deprecated and will be removed in v2.*.*" % name), DeprecationWarning) | ||
| warnings.warn( | ||
| f"The {name} method is deprecated and will be removed in v2.*.*", | ||
| DeprecationWarning, | ||
| ) | ||
|
|
There was a problem hiding this comment.
Function _deprecated.with_warning refactored with the following changes:
- Replace interpolated string formatting with f-string (
replace-interpolation-with-fstring)
Comment on lines
-242
to
+257
| if not (values and all(_is_uint(x) for x in values)): | ||
| return "" | ||
|
|
||
| return _encode(values, self._salt, self._min_length, self._alphabet, self._separators, self._guards) | ||
| return ( | ||
| _encode( | ||
| values, | ||
| self._salt, | ||
| self._min_length, | ||
| self._alphabet, | ||
| self._separators, | ||
| self._guards, | ||
| ) | ||
| if (values and all(_is_uint(x) for x in values)) | ||
| else "" | ||
| ) |
There was a problem hiding this comment.
Function Hashids.encode refactored with the following changes:
- Swap if/else branches of if expression to remove negation (
swap-if-expression) - Lift code into else after jump in control flow (
reintroduce-else) - Replace if statement with if expression (
assign-if-exp)
Sourcery Code Quality Report❌ Merging this PR will decrease code quality in the affected files by 0.42%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch
masterrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
masterbranch, then run:Help us improve this pull request!