Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple service example #111

Closed
wants to merge 1 commit into from
Closed

Add simple service example #111

wants to merge 1 commit into from

Conversation

hayleyjames
Copy link

This change adds an example based on go-kit's stringsvc1 example. I don't know how your services are organized, so I used a generic project format. The business logic is separated from the transport layer, and there is a client for calling the service.

I hope this might be useful for someone.

Thanks,
Josh

@obeattie
Copy link
Contributor

obeattie commented Feb 14, 2019

Sorry for taking so long to respond to this and thanks for the PR!

While I'd love to include more examples in the repo, this does not seem very minimal. I would prefer if any examples focussed on direct use of the library rather than trying to promote conventions for the structure of calling code. What you have here is very different to how we use Typhon within Monzo, for example.

Does this make sense?

@obeattie
Copy link
Contributor

obeattie commented Mar 5, 2019

Please feel free re-open if you are interested in refining the example 😄

@obeattie obeattie closed this Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants