Deprecate BodyBytes functions #159
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillSewell
changed the title
We have been bitten by subtle bugs that are caused by this function being called on a value (and not a pointer to a value), combined with `consume == false`. Because of this we think the convenience of these functions are not worth the risk.
WillSewell
force-pushed
the
deprecate-BodyBytes
branch
from
4ba433e
to
8e4f5ae
Compare
|
Decided to just warn instead: #160 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been bitten by subtle bugs that are caused by this function being called on a value (and not a pointer to a value), combined with
consume == false.Because of this we think the convenience of these functions are not worth the risk.