Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to test PR's #36

Closed
moodeaudio opened this issue Jun 14, 2019 · 4 comments
Closed

How to test PR's #36

moodeaudio opened this issue Jun 14, 2019 · 4 comments

Comments

@moodeaudio
Copy link
Contributor

I have the 4 PR branches #16, #18, #19, #29 loaded into Git Desktop but I'm not sure how to begin integrating and testing them against the 5.3.1 develop code base.

-Tim

@chris-rudmin
Copy link

@moodeaudio Would you like to test them before you merge them into develop?
If so, you would need to checkout the remote branch. Otherwise you would merge the code, and then do your testing.

@moodeaudio
Copy link
Contributor Author

Depending on which branch is selected as the current branch in Git Desktop I see different versions of the source files under GitHub/moode dir tree.

For example the Develop branch shows version 5.3.1 of playerlib.php while the PR16 branch shows 5.3 and the PR18 branch shows version 4.4.

I don't quite get what happens when PR18 with such old files gets merged into Develop.

@chris-rudmin
Copy link

@moodeaudio If there is a conflict, it won't let you merge. If there is no conflicts then the code changes will be merged. git commits are not atomic (with regards to the file), only the lines of code changed are part of the pull request.

@moodeaudio
Copy link
Contributor Author

Ok got it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants