Handle response from listallinfo when data includes flac files with embedded cue sheets. #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minimize diff from original source
|
Need to shift this as a PR to the develop branch. I might have to create a new PR. |
|
Interesting, changing the base for the PR was as simple as going the title, hitting edit, and changing the drop-down selection from master to develop. This branch has no automatic merge conflicts, but needs a review. |
Closed
minimize diff from original source
This reverts commit 6c85793.
This reverts commit 6f4b451.
Using relative URLs allows the links to work correctly in different branches, as well as in forked repositories. Also added a slash to the br tags, to make them self closing -not that it really matters in markdown...
- Remove dead code - Remove vars not needed for improved in-place update process
- Remove dead code
- Adds support for Pi-4B
- Improve layout - Disable controls when feature is off
- Add srtist and album sort options to genLibraryUTF8Rep() - Improve robustness of phpSetPermissions() - Remove SQL escapeString from wlanpwd update since its now a psk
- Add persistant logging (playerlib) - Add sync and session close before reboot (worker)
- This avoids a low entropy condition that causes wpa_passphrase to just return the input password instead of a generated PSK.
|
Closing in favor of PR #46. The other branches had fallen fairly far behind, and the code in the new PR will be easier to test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I initially noticed this as a problem with some of my discs not showing up when drilling down on the albums page. Problem occurred in cases where multiple .flac files were in the same directory e.g. (disc 1).flac, (disc 2).flac.
Turns out that when responding to
listallinfompd returns the data for the embedded cue/playlist as the last line of data for the file being processed. It does not add a final 'Last-Modified' line, as it would for a file-based playlist. The code that skipped a line after a directory or playlist line was skipping valid data.This same problem (and approach for fixing) might apply to wavepack files with embedded playlists, but I don't have any of those, so limited the fix to just flac files.
I've included sample below that shows return from a directory with three flac files, and three external cue sheets.
Thanks again for MoOde!