Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currenty currentsong.txt is updated if some fields changed, but the comparison
$fileMeta['outrate'] != $hwParamsFormat . $hwParamsCalcrate)
will always fail, cause actually in the file we write$current['output'] . $hwParamsCalcrate . "\n";
.This way the file is updated even when the player is in
stop
orpause
mode.This patch fixes the comparison and adds a comparison
$fileMeta['bitrate'] != $current['bitrate']
to trigger an update of currentsong.txt in case the bitrate changes.