Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix codechecker complaints about PHPUnit naming #16

Closed
abias opened this issue Dec 22, 2021 · 1 comment
Closed

Fix codechecker complaints about PHPUnit naming #16

abias opened this issue Dec 22, 2021 · 1 comment

Comments

@abias
Copy link
Member

abias commented Dec 22, 2021

Github actions started to complain recently about the naming of the existing PHPUnit tests:

FILE: ...r/work/moodle-availability_password/moodle-availability_password/moodle/availability/condition/password/tests/privacy_test.php
------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------
 36 | WARNING | PHPUnit testcase name "availability_password_privacy_test" does not match file name "privacy_test"
    |         | (moodle.PHPUnit.TestCaseNames.NoMatch)
 36 | WARNING | PHUnit class "availability_password_privacy_test" does not have any namespace. It is recommended to add it to the
    |         | "availability_password" namespace, using more levels if needed, in order to match the code being tested
    |         | (moodle.PHPUnit.TestCaseNames.MissingNS)
------------------------------------------------------------------------------------------------------------------------------------

This originates to a change in local_codechecker which was integrated there in moodlehq/moodle-local_codechecker#161

@abias
Copy link
Member Author

abias commented Jul 22, 2022

This was solved recently in ed1535e

@abias abias closed this as completed Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant