Skip to content

Commit

Permalink
[docs] Fix all uses of directional quotes
Browse files Browse the repository at this point in the history
Left and Right single quotes (`‘` and `’`) are converted to a single
quote or apostrophe (`'`).

Left and Right double quotes (`“` and `”`) are converted to a double
quote (`"`).
  • Loading branch information
andrewnicols committed May 6, 2022
1 parent 1d1b71e commit 92296c6
Show file tree
Hide file tree
Showing 7 changed files with 14 additions and 14 deletions.
2 changes: 1 addition & 1 deletion docs/release-notes.md
Expand Up @@ -292,7 +292,7 @@ For the best experience and optimum security, we recommend that you keep your br
- {tracker}`MDL-72118` - Rename "HTML block" to the more easily understood "Text block"
- {tracker}`MDL-72706` - Change default value of "Hidden sections" course format setting
- {tracker}`MDL-72115` - Rename "Miscellaneous" category to "Category 1"
- {tracker}`MDL-72119` - Make Enable xxxxx features consistent (hide menus for disabled features)
- {tracker}`MDL-72119` - Make "Enable xxxxx" features consistent (hide menus for disabled features)

### For administrators

Expand Down
4 changes: 2 additions & 2 deletions general/community/roadmap.md
Expand Up @@ -36,15 +36,15 @@ Working on the Moodle learning platform involves millions of moving parts, and e

The entire user experience from onboarding, into daily teaching/learning and expert customisation of Moodle is the core value of what makes Moodle useful or not in the real world, in fully online and blended modes.

While were working on hundreds of smaller, annoying issues, we are also doing some major re-thinking around what an LMS should be in the next decade and beyond as a tool to empower educators and learners.
While we're working on hundreds of smaller, annoying issues, we are also doing some major re-thinking around what an LMS should be in the next decade and beyond as a tool to empower educators and learners.

#### Enabling all our developers

Our significant community of engaged developers are an amazing group of over 1000 people - many of them make a living being part of the Moodle community.

We are of course working on ways to make Moodle programming easier and better, with better training and support as well as improved APIs, plugins, integrations and support for modern technologies.

However, a particularly exciting initiative is the new Moodle Plugins Service, due in 2021, which will provide an app store experience on which all developers can build financial sustainability for their work, while teachers will have easier access to use hundreds of new plugins in their courses via the web interface, without needing to convince their admins to install code. This will help the entire plugins ecosystem.
However, a particularly exciting initiative is the new Moodle Plugins Service, due in 2021, which will provide an "app store" experience on which all developers can build financial sustainability for their work, while teachers will have easier access to use hundreds of new plugins in their courses via the web interface, without needing to convince their admins to install code. This will help the entire plugins ecosystem.

#### Better integrations between Moodle products

Expand Down
4 changes: 2 additions & 2 deletions general/development/policies/accessibility.md
Expand Up @@ -198,11 +198,11 @@ Moodle aims to comply with the following international legislation where possibl

<!-- cspell:ignore Référentiel -->
<!-- cspell:ignore Général -->
<!-- cspell:ignore dAccessibilité -->
<!-- cspell:ignore d'Accessibilité -->
<!-- cspell:ignore des -->
<!-- cspell:ignore RGAA -->

- [Référentiel Général dAccessibilité des Administrations - RGAA](https://references.modernisation.gouv.fr/rgaa-accessibilite/)
- [Référentiel Général d'Accessibilité des Administrations - RGAA](https://references.modernisation.gouv.fr/rgaa-accessibilite/)

### European Union

Expand Down
10 changes: 5 additions & 5 deletions general/development/process/peer-review.md
Expand Up @@ -305,17 +305,17 @@ When code comes from a HQ developer or external developer who has been contribut

If everything is fine, the peer reviewer submits the issue for integration.

If some additional work is needed or the author specifically asked not to submit for integration yet, the peer reviewer clicks on Finish peer review and the issue state returns to Development in progress. Usually the name of the peer reviewer stays on the issue and if a second peer review is requested it is expected that the same Peer reviewer picks it up. If the peer reviewer is not able to do the second review, they should remove their name and comment about it. Otherwise the issue does not appear on waiting for peer review dashboard. Please remember that not all jira users have permission to submit for integration.
If some additional work is needed or the author specifically asked not to submit for integration yet, the peer reviewer clicks on "Finish peer review" and the issue state returns to "Development in progress". Usually the name of the peer reviewer stays on the issue and if a second peer review is requested it is expected that the same Peer reviewer picks it up. If the peer reviewer is not able to do the second review, they should remove their name and comment about it. Otherwise the issue does not appear on "waiting for peer review" dashboard. Please remember that not all jira users have permission to submit for integration.

### Peer review for external developers

When the code has come from an external developer, the peer reviewer will also help the developer to lead the issue to integration. In this case the peer reviewer should not use Finish peer review button.
When the code has come from an external developer, the peer reviewer will also help the developer to lead the issue to integration. In this case the peer reviewer should not use "Finish peer review" button.

If the issue needs additional work, the peer reviewer comments about the suggested changes but does not change the status of the issue and it remains as Peer review in progress. If the author of the patch does not reply in 4 days, the peer reviewer may select either to complete the patch themselves or reopen the issue. The decision should be based on the amount of work required to complete the solution, for example, changing coding style or commit message, rebasing, backporting, adding testing instructions, etc. should be performed by the peer reviewer. This may require picking the commits into reviewers git branch.
If the issue needs additional work, the peer reviewer comments about the suggested changes but does not change the status of the issue and it remains as "Peer review in progress". If the author of the patch does not reply in 4 days, the peer reviewer may select either to complete the patch themselves or reopen the issue. The decision should be based on the amount of work required to complete the solution, for example, changing coding style or commit message, rebasing, backporting, adding testing instructions, etc. should be performed by the peer reviewer. This may require picking the commits into reviewer's git branch.

It is very important to give the credit to the author of the code by either keeping their authorship on the commit or adding Thanks to XXXX for providing the patch to the commit message. If the author of the patch is not in jira-developers group the special user 'moodle.com' should be entered in Assignee field.
It is very important to give the credit to the author of the code by either keeping their authorship on the commit or adding "Thanks to XXXX for providing the patch" to the commit message. If the author of the patch is not in jira-developers group the special user 'moodle.com' should be entered in Assignee field.

There could be situations when the patch is incomplete, does not fix the original issue, creates regressions or otherwise is not correct. As stated above, the peer reviewer should comment about it and wait for the feedback from the author. If there is no feedback, or the author can not work on this issue any more, and the peer reviewer also does not find it easy and important enough to complete, the issue needs to be reopened. Button Fail peer review (available to HQ developers only) will reset the issue status to Reopened. On this screen peer reviewer should remove assignee, peer reviewer and patch label from the issue. This way issue will become available again for anybody who want to work on it. All communication will remain in comments and issue history.
There could be situations when the patch is incomplete, does not fix the original issue, creates regressions or otherwise is not correct. As stated above, the peer reviewer should comment about it and wait for the feedback from the author. If there is no feedback, or the author can not work on this issue any more, and the peer reviewer also does not find it easy and important enough to complete, the issue needs to be reopened. Button "Fail peer review" (available to HQ developers only) will reset the issue status to "Reopened". On this screen peer reviewer should remove assignee, peer reviewer and "patch" label from the issue. This way issue will become available again for anybody who want to work on it. All communication will remain in comments and issue history.

If the issue has passed peer review but the integrator or tester has raised some questions about it, then normally the developer who created the patch would be expected to respond. If they do no respond quickly enough, then the peer reviewer is expected to step in and take responsibility for the change they reviewed.

Expand Down
4 changes: 2 additions & 2 deletions general/development/process/testing/qa.md
Expand Up @@ -190,7 +190,7 @@ To create a new QA test:
5. In the description field add the test steps (usually between 3 and 10), similar to the issue's [testing instructions](./guide), starting with 'Log in as a teacher...' or similar. It's a good idea to try doing the steps yourself as you write the test.
6. Start some steps with 'Verify that ...' or similar.
7. Click the Create button.
8. Go to the MDL issue and create a has a QA test link to the new QA test, adding a comment This feature is now covered by the QA test MDLQA.....
8. Go to the MDL issue and create a 'has a QA test' link to the new QA test, adding a comment "This feature is now covered by the QA test MDLQA....".

:::note

Expand All @@ -199,7 +199,7 @@ To create a new QA test:
- For OAuth 2 tests and any other tests which require a client ID or secret to be entered, label `credentials_required`.
- For issues which specifically mention in the testing instructions to test in different browsers, use the phrase:

> Test in as many browsers as possible and mention in a comment which ones youve used.
> Test in as many browsers as possible and mention in a comment which ones you've used.
- For an exploratory test, begin the test description with:

Expand Down
2 changes: 1 addition & 1 deletion general/development/tools/mdk.md
Expand Up @@ -250,7 +250,7 @@ Every Moodle release, a new version of MDK is also being released in order to pr
1. Via Homebrew: `brew upgrade moodle-sdk`
1. Run MDK doctor to fix its `masterBranch` configuration. `mdk doctor --fix --masterbranch`
1. Run MDK doctor to check the master instances. `mdk doctor --all`
1. If you don't see an error saying something like stable_master is on branch master instead of MOODLE_XX_STABLE, then you're all good. Otherwise, do a hard reset your master instances:
1. If you don't see an error saying something like "stable_master is on branch master instead of MOODLE_XX_STABLE", then you're all good. Otherwise, do a hard reset your master instances:

```
mdk update -c
Expand Down
2 changes: 1 addition & 1 deletion general/development/tracker/tips/index.md
Expand Up @@ -22,7 +22,7 @@ Quick search can pick up many other keywords, see more information on page [Usin

### Advanced search

To get here either enter something in quick search or go to the link [Tracker search page](https://tracker.moodle.org/issues/?jql=) and switch it to Advanced mode.
To get here either enter something in quick search or go to the link [Tracker search page](https://tracker.moodle.org/issues/?jql=) and switch it to "Advanced" mode.
Now you can enter queries in the Jira Query Language (JQL). Use as many AND, OR and parenthesis as you want. Some examples and interesting subqueries:

| JQL | Description |
Expand Down

0 comments on commit 92296c6

Please sign in to comment.