Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release dates on the release notes #298

Merged
merged 1 commit into from Jul 11, 2022

Conversation

junpataleta
Copy link
Collaborator

@junpataleta junpataleta commented Jul 11, 2022

In the future, perhaps it would be better to just note the planned release date when drafting the new release notes for the next minors. People should be able to determine the actual release status of the version from the indicated release date, right?

In the future, perhaps it would be better to just note the planned
release date when the drafting the new release notes for the next
minors.
@netlify
Copy link

netlify bot commented Jul 11, 2022

Deploy Preview for moodledevdocs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 422611e
🔍 Latest deploy log https://app.netlify.com/sites/moodledevdocs/deploys/62cc06bf3520d30008d62e65
😎 Deploy Preview https://deploy-preview-298--moodledevdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@stronk7
Copy link
Member

stronk7 commented Jul 11, 2022

In the future, perhaps it would be better to just note the planned release date

Yeah, I think this is an step that we can easily skip, at very least for minors, where there aren't delays practically ever. I'd suggest to keep the "release day" point #4 still around, so it's always checked... but +1 to add the date since the beginning, when the minor pages (from template, afaik) are created. Pinging @mickhawkins , coz I think he's the one creating them, not sure if there is any procedure to do that.

Ciao :-)

@github-actions
Copy link
Contributor

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 62 🟢 98 🟢 100 🟢 90 🟢 100 Report
/docs/apis/commonfiles 🟠 70 🟢 96 🟢 100 🟢 100 🟢 100 Report
/general/development/gettingstarted 🟠 80 🟢 96 🟢 100 🟢 90 🟢 100 Report
/general/releases 🟠 80 🟢 96 🟢 100 🟢 100 🟢 100 Report

@stronk7
Copy link
Member

stronk7 commented Jul 11, 2022

More yet... maybe they can be automatically picked from data/versions.json with some helper and we can forget, so every release page will look there to put the release day? Sure @andrewnicols knows about that.

Copy link
Member

@stronk7 stronk7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks simple enough for my abilities, hence 👍

@stronk7 stronk7 merged commit 3e3fb02 into moodle:main Jul 11, 2022
@andrewnicols
Copy link
Member

More yet... maybe they can be automatically picked from data/versions.json with some helper and we can forget, so every release page will look there to put the release day? Sure @andrewnicols knows about that.

#300 raised to implement this

@stronk7
Copy link
Member

stronk7 commented Jul 11, 2022

#300 raised to implement this

Cool, so @mickhawkins only needs to add that to the release template and it will work automagically!

@junpataleta junpataleta deleted the releasedates110722 branch July 20, 2022 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants