New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetch release note dates from metadata #300
Fetch release note dates from metadata #300
Conversation
✅ Deploy Preview for moodledevdocs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the deploy preview of this PR
|
5d7e8ec
to
47cacb8
Compare
Couple of comments:
It looks great, I don't quite understand how those helpers work, but I'm sure you do, super Andrew! Ciao :-) |
47cacb8
to
0e961a7
Compare
0e961a7
to
a9678ed
Compare
Correct - it's known as conditional rendering. You can read more about it here:
We can do that :) We already collect information about versions which aren't yet released - it's something we need to add to https://moodledev.io/general/development/process/release - I notice that it's not a current step for the current list of releases. When we add the new doc page for the next release, we should also be adding the versions.json entry. I've created #302 - which I thought I had already created but hohum. That's to create a script to update the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this, Andrew! It's great to keep adding this king of automatisation to the devdocs!! <3
Yay, well done! 🎈 |
As requested in #298.
This issue introduces a new React component:
This will display the:
I've also updated the page description for the meta tag because the import statement and React tags mess with it.