Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] api/files: Migrate file API docs #59

Merged
merged 1 commit into from Apr 20, 2022
Merged

[docs] api/files: Migrate file API docs #59

merged 1 commit into from Apr 20, 2022

Conversation

andrewnicols
Copy link
Member

@andrewnicols andrewnicols added documentation Improvements or additions to documentation migration Migration of a document from the legacy site labels Apr 19, 2022
@andrewnicols andrewnicols added this to the Migration day milestone Apr 19, 2022
@andrewnicols andrewnicols self-assigned this Apr 19, 2022
@andrewnicols andrewnicols added this to In progress in Migration from Wikimedia via automation Apr 19, 2022
@andrewnicols andrewnicols mentioned this pull request Apr 19, 2022
Open
3 tasks
sarjona
sarjona requested changes Apr 19, 2022
View reviewed changes
Copy link
Member

@sarjona sarjona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These pages look great: I like the way they are organised and their content.
As you'll see, there is only one minor thing to review for merging it! :-)

docs/apis/files/internals.md Outdated Show resolved Hide resolved
Migration from Wikimedia automation moved this from In progress to Review in progress Apr 19, 2022
@andrewnicols
Copy link
Member Author

Thanks Sara,

Good catch on the tracker link.

I've addressed some additional markdown linting, and spelling issues that I hadn't spotted eralier too.

sarjona
sarjona approved these changes Apr 20, 2022
View reviewed changes
Copy link
Member

@sarjona sarjona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Andrew! Thanks for reviewing the patch and addressing a few more things... Well done!! :-)

Migration from Wikimedia automation moved this from Review in progress to Reviewer approved Apr 20, 2022
@sarjona sarjona merged commit a5c1bdf into moodle:main Apr 20, 2022
Migration from Wikimedia automation moved this from Reviewer approved to Done Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarjona sarjona sarjona approved these changes

Assignees

@andrewnicols andrewnicols

Labels
documentation Improvements or additions to documentation migration Migration of a document from the legacy site
Projects
Migration from Wikimedia
  
Done
Milestone
Migration day
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andrewnicols @sarjona