MDL-36051 - Quick Grading in Assignment module does not turn on in so…

…me circumstances * Fixed bug with quick grading when file submission is turned off
moodle · Nov 8, 2012 · 00917ec · 00917ec
1 parent 6109f21
commit 00917ec
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/mod/assign/locallib.php b/mod/assign/locallib.php
@@ -3632,7 +3632,9 @@ private function process_save_grading_options() {
                                                                  'showquickgrading'=>false));
         if ($formdata = $mform->get_data()) {
             set_user_preference('assign_perpage', $formdata->perpage);
-            set_user_preference('assign_filter', $formdata->filter);
+            if (isset($formdata->filter)) {
+                set_user_preference('assign_filter', $formdata->filter);
+            }
         }
     }
 

diff --git a/mod/assign/module.js b/mod/assign/module.js
@@ -127,9 +127,11 @@ M.mod_assign.init_grading_options = function(Y) {
             Y.one('form.gradingoptionsform').submit();
         });
         var filterelement = Y.one('#id_filter');
-        filterelement.on('change', function(e) {
+        if (filterelement) {
-            Y.one('form.gradingoptionsform').submit();
+            filterelement.on('change', function(e) {
-        });
+                Y.one('form.gradingoptionsform').submit();
+            });
+        }
         var quickgradingelement = Y.one('#id_quickgrading');
         if (quickgradingelement) {
             quickgradingelement.on('change', function(e) {