MDL-76583 core_external: Migrate service management to util

moodle · Jan 18, 2023 · 0392551 · 0392551
1 parent caddb45
commit 0392551
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 12 deletions.
diff --git a/lib/external/classes/util.php b/lib/external/classes/util.php
@@ -586,4 +586,32 @@ public static function validate_format($format) {
         return $format;
     }
 
+    /**
+     * Delete all pre-built services (+ related tokens) and external functions information defined in the specified component.
+     *
+     * @param string $component name of component (moodle, mod_assignment, etc.)
+     */
+    public static function delete_service_descriptions($component) {
+        global $DB;
+
+        $params = array($component);
+
+        $DB->delete_records_select(
+            'external_tokens',
+            "externalserviceid IN (SELECT id FROM {external_services} WHERE component = ?)",
+            $params
+        );
+        $DB->delete_records_select(
+            'external_services_users',
+            "externalserviceid IN (SELECT id FROM {external_services} WHERE component = ?)",
+            $params
+        );
+        $DB->delete_records_select(
+            'external_services_functions',
+            "functionname IN (SELECT name FROM {external_functions} WHERE component = ?)",
+            $params
+        );
+        $DB->delete_records('external_services', array('component' => $component));
+        $DB->delete_records('external_functions', array('component' => $component));
+    }
 }
diff --git a/lib/externallib.php b/lib/externallib.php
@@ -102,18 +102,7 @@ function external_create_service_token($servicename, $contextid) {
  * @param string $component name of component (moodle, mod_assignment, etc.)
  */
 function external_delete_descriptions($component) {
-    global $DB;
-
-    $params = array($component);
-
-    $DB->delete_records_select('external_tokens',
-            "externalserviceid IN (SELECT id FROM {external_services} WHERE component = ?)", $params);
-    $DB->delete_records_select('external_services_users',
-            "externalserviceid IN (SELECT id FROM {external_services} WHERE component = ?)", $params);
-    $DB->delete_records_select('external_services_functions',
-            "functionname IN (SELECT name FROM {external_functions} WHERE component = ?)", $params);
-    $DB->delete_records('external_services', array('component'=>$component));
-    $DB->delete_records('external_functions', array('component'=>$component));
+    util::delete_service_descriptions($component);
 }
 
 /**