MDL-49560 webservice: avoid recursion in soap

Thanks to El Leonidych for providing a patch
moodle · May 26, 2015 · 0676b9c · 0676b9c
1 parent 5c5fb8b
commit 0676b9c
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/webservice/soap/locallib.php b/webservice/soap/locallib.php
@@ -273,11 +273,6 @@ protected function send_error($ex=null) {
      */
     protected function generate_simple_struct_class(external_single_structure $structdesc) {
         global $USER;
-        // let's use unique class name, there might be problem in unit tests
-        $classname = 'webservices_struct_class_000000';
-        while(class_exists($classname)) {
-            $classname++;
-        }
 
         $fields = array();
         foreach ($structdesc->keys as $name => $fieldsdesc) {
@@ -286,6 +281,12 @@ protected function generate_simple_struct_class(external_single_structure $struc
                         '    public $'.$name.';';
         }
 
+        // We do this after the call to get_phpdoc_type() to avoid duplicate class creation.
+        $classname = 'webservices_struct_class_000000';
+        while (class_exists($classname)) {
+            $classname++;
+        }
+
         $code = '
 /**
  * Virtual struct class for web services for user id '.$USER->id.' in context '.$this->restricted_context->id.'.