MDL-71373 core_enrol: localize "close" in role manager.

moodle · May 14, 2021 · 0c3a643 · 0c3a643
1 parent c9be7c7
commit 0c3a643
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/admin/tool/usertours/templates/tourstep.mustache b/admin/tool/usertours/templates/tourstep.mustache
@@ -58,9 +58,9 @@
     <div class="modal-body" data-placeholder="body">
     </div>
     <div class="modal-footer">
-      <button type="button" class="btn btn-secondary" data-role="previous">{{# str }} previouspage, moodle {{/ str }}</button>
-      <button type="button" class="btn btn-primary" data-role="next">{{# str }} nextpage, moodle {{/ str }}</button>
-      <button class="btn btn-secondary" data-role="end"> {{# str }} endtour, tool_usertours {{/ str }} </button>
+      <button type="button" class="btn btn-secondary" data-role="previous" aria-label="{{# str }} previouspage, moodle {{/ str }}">{{# str }} previouspage, moodle {{/ str }}</button>
+      <button type="button" class="btn btn-primary" data-role="next" aria-label="{{# str }} nextpage, moodle {{/ str }}">{{# str }} nextpage, moodle {{/ str }}</button>
+      <button class="btn btn-secondary" data-role="end" aria-label="{{# str }} endtour, tool_usertours {{/ str }}"> {{# str }} endtour, tool_usertours {{/ str }} </button>
     </div>
   </div>
 </div>
diff --git a/enrol/yui/rolemanager/rolemanager.js b/enrol/yui/rolemanager/rolemanager.js
@@ -366,7 +366,8 @@ YUI.add('moodle-enrol-rolemanager', function(Y) {
             var i, m = this.get(MANIPULATOR);
             var element = Y.Node.create('<div class="popover popover-bottom"><div class="arrow"></div>' +
                                         '<div class="header popover-title">' +
-                                        '<div role="button" class="close" aria-label="Close">' +
+                                        '<div role="button" class="close" aria-label="' +
+                                        M.util.get_string('closebuttontitle', 'moodle') + '">' +
                                         '<span aria-hidden="true">&times;</span></div>' +
                                         '<h3>'+M.util.get_string('assignroles', 'role')+'</h3>' +
                                         '</div><div class="content popover-content form-inline form-group"></div></div>');

diff --git a/lib/tests/tablelib_test.php b/lib/tests/tablelib_test.php
@@ -142,7 +142,7 @@ public function test_has_next_pagination() {
         $headers = $this->generate_headers(2);
 
         // Search for pagination controls containing 'page-link"\saria-label="Next"'.
-        $this->expectOutputRegex('/page-link"\saria-label="Next"/');
+        $this->expectOutputRegex('/page-link"\saria-label="Next page"/');
 
         $this->run_table_test(
             $columns,