Some little fixes

moodle · Jan 2, 2003 · 1421704 · 1421704
1 parent 5422d75
commit 1421704
Show file tree

Hide file tree

Showing 7 changed files with 13 additions and 11 deletions.
diff --git a/admin/auth.php b/admin/auth.php
@@ -18,6 +18,7 @@
 
 	if ($config = data_submitted()) {
 
+        $config = (array)$config;
         validate_form($config, $err);
 
         if (count($err) == 0) {
@@ -39,7 +40,7 @@
 
 /// Otherwise fill and print the form.
 
-    if (!isset($config)) {
+    if (empty($config)) {
         $config = $CFG;
     }
 

diff --git a/admin/config.php b/admin/config.php
@@ -68,10 +68,10 @@
 
 /// Otherwise fill and print the form.
 
-    if (!isset($config)) {
+    if (empty($config)) {
         $config = $CFG;
     }
-    if (!isset($focus)) {
+    if (empty($focus)) {
         $focus = "";
     }
 

diff --git a/course/editsection.php b/course/editsection.php
@@ -39,7 +39,7 @@
 
 /// Otherwise fill and print the form.
 
-    if (! $form ) {
+    if (empty($form)) {
         $form = $section;
     }
 

diff --git a/lib/moodlelib.php b/lib/moodlelib.php
@@ -508,7 +508,7 @@ function authenticate_user_login($username, $password) {
 
     $md5password = md5($password);
 
-    if (!isset($CFG->auth)) {
+    if (empty($CFG->auth)) {
         $CFG->auth = "email";    // Default authentication module
     }
 

diff --git a/login/change_password.php b/login/change_password.php
@@ -65,17 +65,18 @@
         $frm->id = $id;
     }
 
-	if (!$frm->username)
+	if (empty($frm->username)) {
     	$frm->username = get_moodle_cookie();
+    }
 
-	if ($frm->username) {
+	if (!empty($frm->username)) {
     	$focus = "form.password";
 	} else {
     	$focus = "form.username";
 	}
 
     $strchangepassword = get_string("changepassword");
-    if ($course->id) {
+    if (!empty($course->id)) {
 	    print_header($strchangepassword, $strchangepassword,
                      "<A HREF=\"$CFG->wwwroot/course/view.php?id=$course->id\">$course->shortname</A> ->
                       <A HREF=\"$CFG->wwwroot/user/index.php?id=$course->id\">".get_string("participants")."</A> ->

diff --git a/login/forgot_password.php b/login/forgot_password.php
@@ -34,8 +34,8 @@
 		}
 	}
 
-	if ( empty($frm->email) ) {
-		if ( $username = get_moodle_cookie() ) {
+	if (empty($frm->email)) {
+		if ($username = get_moodle_cookie() ) {
 			$frm->email = get_field("user", "email", "username", "$username");
 		}
 	}

diff --git a/login/signup.php b/login/signup.php
@@ -37,7 +37,7 @@
         $focus = 'form.' . array_shift(array_flip(get_object_vars($err)));
     }
 
-    if (!$user->country and $CFG->country) {
+    if (empty($user->country) and !empty($CFG->country)) {
         $user->country = $CFG->country;
     }