Merge branch 'MDL-63150-36' of git://github.com/peterRd/moodle into M…

…OODLE_36_STABLE
moodle · Dec 12, 2018 · 1641091 · 1641091
2 parents 6b39117 + 8a1ebcf
commit 1641091
Show file tree

Hide file tree

Showing 2 changed files with 59 additions and 3 deletions.
diff --git a/mod/url/lib.php b/mod/url/lib.php
@@ -379,15 +379,22 @@ function url_check_updates_since(cm_info $cm, $from, $filter = array()) {
  *
  * @param calendar_event $event
  * @param \core_calendar\action_factory $factory
+ * @param int $userid ID override for calendar events
  * @return \core_calendar\local\event\entities\action_interface|null
  */
 function mod_url_core_calendar_provide_event_action(calendar_event $event,
-                                                       \core_calendar\action_factory $factory) {
-    $cm = get_fast_modinfo($event->courseid)->instances['url'][$event->instance];
+                                                       \core_calendar\action_factory $factory, $userid = 0) {
+
+    global $USER;
+    if (empty($userid)) {
+        $userid = $USER->id;
+    }
+
+    $cm = get_fast_modinfo($event->courseid, $userid)->instances['url'][$event->instance];
 
     $completion = new \completion_info($cm->get_course());
 
-    $completiondata = $completion->get_data($cm, false);
+    $completiondata = $completion->get_data($cm, false, $userid);
 
     if ($completiondata->completionstate != COMPLETION_INCOMPLETE) {
         return null;

diff --git a/mod/url/tests/lib_test.php b/mod/url/tests/lib_test.php
@@ -116,6 +116,55 @@ public function test_url_view() {
         $this->assertEquals(1, $completiondata->completionstate);
     }
 
+    /**
+     * Test mod_url_core_calendar_provide_event_action with user override
+     */
+    public function test_url_core_calendar_provide_event_action_user_override() {
+        global $CFG, $USER;
+
+        $this->resetAfterTest();
+        $this->setAdminUser();
+        $user = $this->getDataGenerator()->create_user();
+        $CFG->enablecompletion = 1;
+
+        // Create the activity.
+        $course = $this->getDataGenerator()->create_course(array('enablecompletion' => 1));
+        $url = $this->getDataGenerator()->create_module('url', array('course' => $course->id),
+            array('completion' => 2, 'completionview' => 1, 'completionexpected' => time() + DAYSECS));
+
+        // Get some additional data.
+        $cm = get_coursemodule_from_instance('url', $url->id);
+
+        // Create a calendar event.
+        $event = $this->create_action_event($course->id, $url->id,
+            \core_completion\api::COMPLETION_EVENT_TYPE_DATE_COMPLETION_EXPECTED);
+
+        // Mark the activity as completed.
+        $completion = new completion_info($course);
+        $completion->set_module_viewed($cm);
+
+        // Create an action factory.
+        $factory = new \core_calendar\action_factory();
+
+        // Decorate action event.
+        $actionevent = mod_url_core_calendar_provide_event_action($event, $factory, $USER->id);
+
+        // Decorate action with a userid override.
+        $actionevent2 = mod_url_core_calendar_provide_event_action($event, $factory, $user->id);
+
+        // Ensure result was null because it has been marked as completed for the associated user.
+        // Logic was brought across from the "_already_completed" function.
+        $this->assertNull($actionevent);
+
+        // Confirm the event was decorated.
+        $this->assertNotNull($actionevent2);
+        $this->assertInstanceOf('\core_calendar\local\event\value_objects\action', $actionevent2);
+        $this->assertEquals(get_string('view'), $actionevent2->get_name());
+        $this->assertInstanceOf('moodle_url', $actionevent2->get_url());
+        $this->assertEquals(1, $actionevent2->get_item_count());
+        $this->assertTrue($actionevent2->is_actionable());
+    }
+
     public function test_url_core_calendar_provide_event_action() {
         $this->resetAfterTest();
         $this->setAdminUser();