Skip to content

Commit

Permalink
MDL-80676 core: Remove unnecessary aria-labelledby for action menu links
Browse files Browse the repository at this point in the history
The aria-labelledby attribute for the action menu link's <a> tag is
unnecessary as the <span> tag containing the action menu link's text
is already within the <a> tag and already serves as the link's label by
default.
  • Loading branch information
junpataleta committed Jan 19, 2024
1 parent 810554e commit 1764718
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions lib/templates/action_menu_link.mustache
Expand Up @@ -27,12 +27,12 @@
}
}}
{{^disabled}}
<a href="{{url}}" class="{{$actionmenulinkclasses}}aabtn {{classes}}{{/actionmenulinkclasses}}" {{#attributes}}{{name}}="{{value}}" {{/attributes}}{{#showtext}}aria-labelledby="actionmenuaction-{{instance}}"{{/showtext}}>
<a href="{{url}}" class="{{$actionmenulinkclasses}}aabtn {{classes}}{{/actionmenulinkclasses}}" {{#attributes}}{{name}}="{{value}}" {{/attributes}}>
{{#icon}}
{{#pix}}{{key}}, {{component}}, {{title}}{{/pix}}
{{/icon}}
{{#showtext}}
<span class="menu-action-text" id="actionmenuaction-{{instance}}">{{{text}}}</span>
<span class="menu-action-text">{{{text}}}</span>
{{/showtext}}
</a>
{{/disabled}}
Expand Down

0 comments on commit 1764718

Please sign in to comment.