MDL-9432 - Forgot to return success/failure in two places.

moodle · Apr 19, 2007 · 181190d · 181190d
1 parent 8f290d7
commit 181190d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/question/type/match/questiontype.php b/question/type/match/questiontype.php
@@ -610,6 +610,8 @@ function restore_recode_answer($state, $restore) {
      * @return bool success or failure.
      */ 
     function decode_content_links_caller($questionids, $restore, &$i) {
+        $status = true;
+
         // Decode links in the question_match_sub table.
         if ($subquestions = get_records_list('question_match_sub', 'question',
                 implode(',',  $questionids), '', 'id, questiontext')) {
@@ -633,6 +635,8 @@ function decode_content_links_caller($questionids, $restore, &$i) {
                 }
             }
         }
+
+        return $status;
     }
 }
 //// END OF CLASS ////

diff --git a/question/type/multichoice/questiontype.php b/question/type/multichoice/questiontype.php
@@ -560,6 +560,8 @@ function restore_recode_answer($state, $restore) {
      * @return bool success or failure.
      */ 
     function decode_content_links_caller($questionids, $restore, &$i) {
+        $status = true;
+
         // Decode links in the question_multichoice table.
         if ($multichoices = get_records_list('question_multichoice', 'question',
                 implode(',',  $questionids), '', 'id, correctfeedback, partiallycorrectfeedback, incorrectfeedback')) {
@@ -589,6 +591,8 @@ function decode_content_links_caller($questionids, $restore, &$i) {
                 }
             }
         }
+
+        return $status;
     }
 }
 //// END OF CLASS ////