Skip to content

Commit

Permalink
MDL-75625 core_courseformat: fix MDL-71979 comments
Browse files Browse the repository at this point in the history
  • Loading branch information
ferranrecio committed Sep 1, 2022
1 parent 952d9e9 commit 188d304
Show file tree
Hide file tree
Showing 8 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion course/format/amd/build/local/content/actions.min.js.map

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions course/format/amd/src/local/content/actions.js
Expand Up @@ -35,7 +35,7 @@ import {getList} from 'core/normalise';
import * as CourseEvents from 'core_course/events';
import Pending from 'core/pending';
import ContentTree from 'core_courseformat/local/courseeditor/contenttree';
// The jQuery module is only used for interacting with Boostrap 4. It can we removed when MDL-79179 is integrated.
// The jQuery module is only used for interacting with Boostrap 4. It can we removed when MDL-71979 is integrated.
import jQuery from 'jquery';

// Load global strings.
Expand Down Expand Up @@ -261,7 +261,7 @@ export default class extends BaseComponent {
);

// Open the cm section node if possible (Bootstrap 4 uses jQuery to interact with collapsibles).
// All jQuery int this code can be replaced when MDL-79179 is integrated.
// All jQuery int this code can be replaced when MDL-71979 is integrated.
const sectionnode = currentElement.closest(this.selectors.SECTIONNODE);
const toggler = jQuery(sectionnode).find(this.selectors.MODALTOGGLER);
let collapsibleId = toggler.data('target') ?? toggler.attr('href');
Expand Down
4 changes: 2 additions & 2 deletions course/format/amd/src/local/courseeditor/contenttree.js
Expand Up @@ -61,7 +61,7 @@ export default class extends Tree {
return this._getVisibleItems();
};
}
// All jQuery events can be replaced when MDL-79179 is integrated.
// All jQuery events can be replaced when MDL-71979 is integrated.
this.treeRoot.on('hidden.bs.collapse shown.bs.collapse', () => {
this.refreshVisibleItemsCache();
});
Expand Down Expand Up @@ -146,7 +146,7 @@ export default class extends Tree {
* @param {JQuery} item the jQuery object
*/
toggleGroup(item) {
// All jQuery in this segment of code can be replaced when MDL-79179 is integrated.
// All jQuery in this segment of code can be replaced when MDL-71979 is integrated.
const toggler = item.find(this.selectors.COLLAPSE);
let collapsibleId = toggler.data('target') ?? toggler.attr('href');
if (!collapsibleId) {
Expand Down
2 changes: 1 addition & 1 deletion course/format/amd/src/local/courseindex/courseindex.js
Expand Up @@ -192,7 +192,7 @@ export default class Component extends BaseComponent {

// Course index is based on Bootstrap 4 collapsibles. To collapse them we need jQuery to
// interact with collapsibles methods. Hopefully, this will change in Bootstrap 5 because
// it does not require jQuery anymore (when MDL-79179 is integrated).
// it does not require jQuery anymore (when MDL-71979 is integrated).
const togglerValue = (forceValue) ? 'show' : 'hide';
jQuery(collapsible).collapse(togglerValue);
}
Expand Down
2 changes: 1 addition & 1 deletion theme/boost/amd/build/footer-popover.min.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion theme/boost/amd/src/footer-popover.js
Expand Up @@ -36,7 +36,7 @@ export const init = () => {
const container = document.querySelector(SELECTORS.FOOTERCONTAINER);
const footerButton = document.querySelector(SELECTORS.FOOTERBUTTON);

// All jQuery in this code can be replaced when MDL-79179 is integrated.
// All jQuery in this code can be replaced when MDL-71979 is integrated.
$(footerButton).popover({
content: getFooterContent,
container: container,
Expand Down

0 comments on commit 188d304

Please sign in to comment.