MDL-77718 editor_tiny: Restrict the revision to int for loaders

The revision should always be an int. I suspect this was missed during debugging and not corrected.
moodle · Apr 19, 2023 · 1d16c04 · 1d16c04
1 parent 4d46352
commit 1d16c04
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/lib/editor/tiny/lang.php b/lib/editor/tiny/lang.php
@@ -74,10 +74,10 @@ protected function parse_file_information_from_url(): void {
             }
 
             [$rev, $lang] = explode('/', $slashargument, 2);
-            $rev  = min_clean_param($rev, 'RAW');
+            $rev  = min_clean_param($rev, 'INT');
             $lang = min_clean_param($lang, 'SAFEDIR');
         } else {
-            $rev  = min_optional_param('rev', 0, 'RAW');
+            $rev  = min_optional_param('rev', 0, 'INT');
             $lang = min_optional_param('lang', 'standard', 'SAFEDIR');
         }
 

diff --git a/lib/editor/tiny/loader.php b/lib/editor/tiny/loader.php
@@ -74,10 +74,10 @@ protected function parse_file_information_from_url(): void {
             }
 
             [$rev, $filepath] = explode('/', $slashargument, 2);
-            $this->rev  = min_clean_param($rev, 'RAW');
+            $this->rev  = min_clean_param($rev, 'INT');
             $this->filepath = min_clean_param($filepath, 'SAFEPATH');
         } else {
-            $this->rev  = min_optional_param('rev', 0, 'RAW');
+            $this->rev  = min_optional_param('rev', 0, 'INT');
             $this->filepath = min_optional_param('filepath', 'standard', 'SAFEPATH');
         }