MDL-31499 Javascript: Handle invalid window names in openpopup

moodle · Sep 24, 2012 · 1d2173a · 1d2173a
1 parent a3ab18c
commit 1d2173a
Showing 1 changed file with 9 additions and 0 deletions.
diff --git a/lib/javascript-static.js b/lib/javascript-static.js
@@ -1200,6 +1200,15 @@ function openpopup(event, args) {
         }
     }
 
+    // Cleans window name because IE does not support funky ones.
+    var nameregex = /[^a-z0-9_]/i;
+    if (args.name.match(nameregex)) {
+        args.name = args.name.replace(nameregex, '_');
+        if (M.cfg.developerdebug) {
+            alert('DEVELOPER NOTICE: Invalid \'name\' passed to openpopup()');
+        }
+    }
+
     var fullurl = args.url;
     if (!args.url.match(/https?:\/\//)) {
         fullurl = M.cfg.wwwroot + args.url;