Skip to content

Commit

Permalink
MDL-37514 module.js: fix .js for auto quiz submission in preview mode
Browse files Browse the repository at this point in the history
The issue: when we attempt the quiz as teacher/admin and timer is up,
quiz is not submitted, even though "Open attempts are submitted
automatically" is set. I've changed the javascript for a timer,
responsible for submission, removing the special behaviour in case of
preview mode. Note, that when the admin/teacher is taking a quiz, the
"preview" mode is automatically switched on.

It is a bit strange, since in the javascript there was clearly no
expressed intention to really submit quiz in preview, even when timer
hits. It does not really seem like a accidental bug, rather it looks
like some misunderstanding. Worse still, it may happen that I did not
understand the intentions of previous editor and ruined some
functionality. Because of this, and the fact that this is my first bug,
I would like to ask about the peer review! Please, see my comments in
bug discussion for the testing steps.
  • Loading branch information
nailbiter authored and danpoltawski committed Apr 22, 2013
1 parent e1267ba commit 22687af
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions mod/quiz/module.js
Expand Up @@ -96,13 +96,7 @@ M.mod_quiz.timer = {
var Y = M.mod_quiz.timer.Y;
var secondsleft = Math.floor((M.mod_quiz.timer.endtime - new Date().getTime())/1000);

// If this is a preview and time expired, display timeleft 0 and don't renew the timer.
if (M.mod_quiz.timer.preview && secondsleft < 0) {
Y.one('#quiz-time-left').setContent('0:00:00');
return;
}

// If time has expired, Set the hidden form field that says time has expired.
// If time has expired, set the hidden form field that says time has expired and submit
if (secondsleft < 0) {
M.mod_quiz.timer.stop(null);
Y.one('#quiz-time-left').setContent(M.str.quiz.timesup);
Expand Down

0 comments on commit 22687af

Please sign in to comment.